Establish series/2.x against specs2 v5 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and reformatted the fragments a bit to look better when using Scala 3
armanbilge
commented
Nov 1, 2021
| @@ -27,14 +27,16 @@ import org.specs2.SpecificationLike | |||
| import org.specs2.specification.core.Fragments | |||
| import org.specs2.scalacheck.Parameters | |||
|
|
|||
| import scala.language.implicitConversions | |||
There was a problem hiding this comment.
Needing this import on Scala 3 is troubling.
There was a problem hiding this comment.
Nope, nevermind. This is right I think.
There was a problem hiding this comment.
This is warning btw:
[warn] -- Feature Warning: /workspace/discipline-specs2/core/src/main/scala/org/typelevel/discipline/specs2/mutable/Discipline.scala:40:55
[warn] 40 | if (n != ruleSet.all.properties.toList.size - 1) br
[warn] | ^^
[warn] |Use of implicit conversion object given_Conversion_Fragment_Fragments in object Fragments should be enabled
[warn] |by adding the import clause 'import scala.language.implicitConversions'
[warn] |or by setting the compiler option -language:implicitConversions.
[warn] |See the Scala docs for value scala.language.implicitConversions for a discussion
[warn] |why the feature should be explicitly enabled.
vasilmkd
approved these changes
Nov 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #207.