Skip to content

Commit

Permalink
remove double-testing of Volarized tsc
Browse files Browse the repository at this point in the history
  • Loading branch information
machty committed Jan 9, 2025
1 parent 2b808a4 commit ed03f60
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 43 deletions.
2 changes: 1 addition & 1 deletion packages/core/__tests__/cli/incremental.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const BUILD_INFO = 'tsconfig.tsbuildinfo';
const INPUT_SCRIPT = 'index.gts';

describe('CLI: --incremental', () => {
test.only('when no build has occurred', async () => {
test('when no build has occurred', async () => {
let project = await Project.create({ glint: { environment: 'ember-template-imports' } });

let code = stripIndent`
Expand Down
42 changes: 0 additions & 42 deletions packages/core/__tests__/cli/watch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ describe('CLI: watched typechecking', () => {
output = await watch.awaitOutput('Watching for file changes.');
expect(output).toMatch('Found 0 errors.');

expect(watch.allOutput).toMatch(/\033c/); // output should include screen reset control sequence

await watch.terminate();
});

Expand Down Expand Up @@ -290,44 +288,4 @@ describe('CLI: watched typechecking', () => {

await watch.terminate();
});

test('reports on errors introduced and cleared during the watch with --preserveWatchOutput', async () => {
let code = stripIndent`
import Component from '@glimmer/component';
type ApplicationArgs = {
version: string;
};
export default class Application extends Component<{ Args: ApplicationArgs }> {
private startupTime = new Date().toISOString();
<template>
Welcome to app v{{@version}}.
The current time is {{this.startupTime}}.
</template>
}
`;

project.write('index.gts', code);

let watch = project.checkWatch({ flags: ['--preserveWatchOutput'], reject: true });

let output = await watch.awaitOutput('Watching for file changes.');
expect(output).toMatch('Found 0 errors.');

project.write('index.gts', code.replace('this.startupTime', 'this.startupTimee'));

output = await watch.awaitOutput('Watching for file changes.');
expect(output).toMatch('Found 1 error.');

project.write('index.gts', code);

output = await watch.awaitOutput('Watching for file changes.');
expect(output).toMatch('Found 0 errors.');

expect(watch.allOutput).not.toMatch(/\033c/); // output should not include screen reset control sequence

await watch.terminate();
});
});

0 comments on commit ed03f60

Please sign in to comment.