Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #45

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Update deps #45

merged 1 commit into from
Feb 25, 2024

Conversation

rukai
Copy link
Collaborator

@rukai rukai commented Feb 25, 2024

Notable improvements is the move of derive_builder to syn 2.0, allowing users to eliminate the duplicate syn 1.0 from their dep tree.

Codegen:

I verified that cargo run -p protocol_codegen still succeeds.

kafka-protocol crate:

The changelog does not list anything that would break compilation or runtime behavior for users https://github.com/colin-kiegel/rust-derive-builder/blob/master/derive_builder/CHANGELOG.md
So I believe this can be released as a non-breaking change.

@tychedelia tychedelia self-assigned this Feb 25, 2024
@tychedelia
Copy link
Owner

Great! Just leaving a note here about a discussion we had in #41 to potentially move the builder generation into the crate, but this is a great improvement for now.

Even though this isn't a breaking change, I may wait to see if #44 clears on Monday to bundle these together. Leave a review there if you have any concerns.

@tychedelia tychedelia merged commit 74b8fba into tychedelia:main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants