Replace software implementation of castagnoli crc32 with hardware implementation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rukai sorry for being MIA, have been in the process of moving cross country. Will review this shortly! |
|
No worries, hope your move goes well! |
|
Just released https://crates.io/crates/kafka-protocol/0.7.0 including this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that castagnoli crc was a bottleneck in our application, this PR swaps our castagnoli crc implementation to a hardware implementation which should improve performance significantly when the hardware is available.
I made this PR upstream to add a comparison between crc32c and crc crates but here are the results on my machine which has the required 4.2 SSE available:
crc32c vastly outperforms crc, it is getting throughputs of ~6GiB/s while crc is getting throughputs of ~500MiB/s