This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
Update Kubernetes object labels #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces waiter-cluster label. See #721.
shamsimam
reviewed
Jun 5, 2019
| :waiter-cluster cluster-name | ||
| :waiter/cluster cluster-name | ||
| :waiter/service-hash service-hash | ||
| :waiter/user run-as-user} |
There was a problem hiding this comment.
In a separate PR, we should perform a length check on the run-as-user label and trim accordingly.
There was a problem hiding this comment.
The OS ensures that isn't a problem: user names already have a length limit of 32 chars on posix systems.
| :labels {:app k8s-name | ||
| ;; TODO - remove waiter-cluster | ||
| ;; after waiter/cluster is exclusively in use | ||
| ;; (see GitHub issue #721) | ||
| :waiter-cluster cluster-name |
There was a problem hiding this comment.
Are we preserving the waiter-cluster label for backwards compatibility? Or is there a plan to remove it in a subsequent PR?
There was a problem hiding this comment.
We're going to remove it in the near future, but we need to allow time for all the current services to be restarted. We probably won't remove it until after the ReplicaSet → Pod refactoring.
shamsimam
approved these changes
Jun 5, 2019
|
@shamsimam - RTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
service-id->k8s-app-namedocstringwaiter/clusterKubernetes labelwaiter/service-hashKubernetes labelWhy are we making these changes?
waiter/clusterlabel helps address Rename waiter-cluster K8s label to waiter/cluster for consistency #721.waiter/service-hashlabel will make it easier to search for Kubernetes objects corresponding to a specific Waiter service. Since the existingwaiter/service-idis an annotation (due to label length limitations), it can't be used in Kubernetes selectors when searching.