STC and PSAR performance improvements #777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two updates in this PR to address the next slowest indicators. Also a proposed logic change to PSAR see below
STC - All I was able to do was to combine the 2 for loops into 1. Performance is around twice as fast as previous version
Orig STC
NEW STC
PSAR - Using Numpy arrays within the for loop has resulted in some decent improvements.
ORIG PSAR
NEW PSAR
Proposed logic change for PSAR
The original version did not include row 1 when calculating the long and short values. I don't know if that is intentional. The updated code starts at row 1 in the for loop with
for row in range(1, m):
rather thanfor row in range(2, m):
The results of the old and the new compare like this