Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create image with required files #744

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Mar 4, 2025

Fixes

This has been tested locally by creating container out of image with the changes in current PR.

root@3b861089fc6f:/twilio# ls
Gemfile  Gemfile.lock  LICENSE	README.md  Rakefile  lib  pkg  twilio-ruby.gemspec 

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sbansla sbansla requested a review from shrutiburman March 4, 2025 11:46
.dockerignore Outdated
@@ -1 +1,2 @@
Gemfile.lock
.git/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than ignoring it here why dont we just copy only what's needed in the Dockerflie ?
Change this

COPY . .
to only copy src, tests, etc folder.

Copy link
Contributor

@shrutiburman shrutiburman Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Mar 4, 2025

@sbansla sbansla changed the title chore: ignoring .git folder in docker image chore: create image with required files Mar 4, 2025
@sbansla sbansla merged commit 7a4151e into main Mar 4, 2025
30 checks passed
@sbansla sbansla deleted the fix-dockerfile-to-copy-only-code branch March 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants