186 style scroll chat composer #189
Conversation
…umPicker component useEffect callback
add changeset and update changeset version
…umPicker component useEffect callback
There was a problem hiding this comment.
I'm not sure how to proceed, but I don't think we can push this styling. It seems like maybe lexical/Paste should anticipate that there's going to be a button in its context and react accordingly. Instead we have two internal components with no clear way to style them (as you've identified.)
| editor.dispatchCommand(CLEAR_EDITOR_COMMAND, undefined); | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
I found the CustomizationProvider (below) which should allow us to do a better job of styling. As-is, I don't think we can ship it, it looks way too odd to me. But maybe we can target the individual elements better to style them in a way that makes more sense.
| "turbo": "^1.2.16" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
These dependencies should be in the UI package, not up at the top - these aren't necessary for the dev-phone-plugin
|
|
||
| <Grid gutter={"space20"} marginBottom="space40"> | ||
| <Column span={12}> | ||
| <ChatComposer |
There was a problem hiding this comment.
I simplified the use of Paste here, I don't think we can componentize our way out of this. I have no idea how lexical manages this - I tried using Flexbox and the button just floats left. But there must be some way to manage it sensibly.
The Chat Composer button is positioned to the left and sits underneath the text input which makes it an awkward location for a submission button. This PR fixes that issue along with increasing the height of the soft phone and adding a scrollbar to the softphone since the Chat Composer grows vertically with the content inside of it.
Contributing to Twilio