Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): run typos-cli on project #832

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

mkatychev
Copy link
Contributor

chore(lint): run typos on project

Description

  • Ran typos -w on the project
  • Added typos.toml config file

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

@mkatychev
Copy link
Contributor Author

NOTE: Not sure if it's worth the evaluation time to add pkgs.typos to the flake checks but it may be better to be done as a follow-up.

Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tool 👍 Thanks for bringing it to our attention.

The I/O tester for Bash is failing on this branch, for "reasons". However, it's very unlikely to have anything to do with your changes. As such, I think I'm good to approve this once my suggestions have been addressed.

typos.toml Outdated Show resolved Hide resolved
typos.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Xophmeister
Copy link
Member

NOTE: Not sure if it's worth the evaluation time to add pkgs.typos to the flake checks but it may be better to be done as a follow-up.

I've added this as an issue, but feel free to add it to this PR. I think the runtime of the CI is already quite long, so adding this isn't going to do much harm 😅

If you do choose to add it, please update the CHANGELOG accordingly and -- I insist -- credit yourself 🙏

Co-authored-by: Christopher Harrison <[email protected]>
@mkatychev
Copy link
Contributor Author

NOTE: Not sure if it's worth the evaluation time to add pkgs.typos to the flake checks but it may be better to be done as a follow-up.

I've added this as an issue, but feel free to add it to this PR. I think the runtime of the CI is already quite long, so adding this isn't going to do much harm 😅

If you do choose to add it, please update the CHANGELOG accordingly and -- I insist -- credit yourself 🙏

I'd like to do that in a separate PR once I get around to it.

@mkatychev mkatychev requested a review from Xophmeister January 16, 2025 21:15
@Xophmeister Xophmeister merged commit 9b2de13 into tweag:main Jan 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants