Include genealogos frontend in the api #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Apr 15, 2024
Co-authored-by: Yann Hamdaoui <[email protected]>
ErinvanderVeen
force-pushed
the
rocket-index-html
branch
from
4a69310 to
4c99a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables rocket to serve the index.html page on the root of its binding address.
Motivation
Previously hosting both the website and the api required the use of some external webserver (like nginx, or simple-http-server). This approach allows the users to forgo that, and just use the builtin rocket server.
Checklist
Checklist before merging: