Merge pull request dart-archive#37 from dart-lang/proper-close

Close output stream on cancel
tvolkert · Feb 12, 2019 · 372d04f · 372d04f
2 parents f3f7b70 + 14c7ae2
commit 372d04f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.1.20
+
+* Close worker `outputStream` on `cancel`.
+
 ## 0.1.19
 
 * Work around https://github.com/dart-lang/sdk/issues/35874.

diff --git a/lib/src/driver/driver_connection.dart b/lib/src/driver/driver_connection.dart
@@ -77,7 +77,10 @@ class StdDriverConnection implements DriverConnection {
   }
 
   @override
-  Future cancel() => _messageGrouper.cancel();
+  Future cancel() async {
+    await _outputStream.close();
+    await _messageGrouper.cancel();
+  }
 }
 
 /// [DriverConnection] that works with an isolate via a [SendPort].

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: bazel_worker
-version: 0.1.19
+version: 0.1.20
 
 description: Tools for creating a bazel persistent worker.
 author: Dart Team <[email protected]>