Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/regexp: Add support for regexp_replace() #986

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

lgualtieri75
Copy link
Contributor

No description provided.

@lgualtieri75 lgualtieri75 force-pushed the main branch 2 times, most recently from fc7d0d7 to cab334a Compare February 11, 2025 18:37
@@ -213,7 +228,7 @@ def validate_percentile_disc(res):


def test_aggregates(pipe):
extension_path = "./target/debug/liblimbo_percentile"
extension_path = "./target/debug/liblimbo_percentile.so"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will need to be changed back, they were just removed in #982 to ensure they work on other systems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

Copy link
Contributor

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@penberg penberg changed the title Add support for REGEXP_REPLACE in limbo extension #740 extensions/regexp: Add support for regexp_replace() Feb 12, 2025
@penberg penberg closed this in cc4ecf4 Feb 12, 2025
@penberg penberg merged commit cc4ecf4 into tursodatabase:main Feb 12, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants