Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating point number truncation in JSON #963

Closed
wants to merge 0 commits into from
Closed

Fix floating point number truncation in JSON #963

wants to merge 0 commits into from

Conversation

lgualtieri75
Copy link
Contributor

@lgualtieri75 lgualtieri75 commented Feb 10, 2025 •
edited by penberg
Loading

Fixes #877

@krishvishal
Copy link
Contributor

krishvishal commented Feb 10, 2025 •
edited
Loading

TIL about ryu.

This is much faster.

penberg
penberg reviewed Feb 10, 2025
View reviewed changes
testing/json.test Outdated
} {{}}
#do_execsql_test json_extract_multiple_null_paths {
# SELECT json_extract(1, null, null, null)
#} {{}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! My bad!

@penberg penberg changed the title fix floating point numbers get truncated in json #877 Fix floating point number truncation in JSON Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penberg penberg penberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

floating point numbers get truncated in json
3 participants
@lgualtieri75 @krishvishal @penberg