Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong count() result if the column specified contains a NULL #1065

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix wrong count() result if the column specified contains a NULL #1065

merged 1 commit into from
Feb 28, 2025

Conversation

lgualtieri75
Copy link
Contributor

@lgualtieri75 lgualtieri75 commented Feb 27, 2025 •
edited by penberg
Loading

Fixes #1064

@lgualtieri75 lgualtieri75 force-pushed the main branch 3 times, most recently from a23c51e to 4183793 Compare February 27, 2025 18:47
@penberg penberg changed the title fix #1064 Fix wrong count() result if the column specified contains a NULL Feb 28, 2025
@penberg
Copy link
Collaborator

penberg commented Feb 28, 2025

@lgualtieri75 Can you write a TCL test for this?

@penberg penberg requested a review from jussisaurio February 28, 2025 12:03
@lgualtieri75
Copy link
Contributor Author

of course, I opened a new PR #1066
because I added a new table for count specific tests, also in preparation to my next pr

@penberg penberg merged commit c5095e8 into tursodatabase:main Feb 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jussisaurio jussisaurio Awaiting requested review from jussisaurio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong count() result if the column specified contains a NULL
2 participants
@lgualtieri75 @penberg