Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev catch #287

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Dev catch #287

merged 2 commits into from
Mar 26, 2024

Conversation

turion
Copy link
Owner

@turion turion commented Feb 8, 2024

Introduces some form of control flow for clocks. Clocks may now throw exceptions, and other clocks can be started as exception handlers.

  • Clean up git history
  • Figure out whether there are ways to catch the clock exception without discarding the state of the clsf
  • Reduce redundancy between IO errors and ExceptT.

@turion turion marked this pull request as draft February 13, 2024 13:33
@turion
Copy link
Owner Author

turion commented Feb 13, 2024

Figure out whether there are ways to catch the clock exception without discarding the state of the clsf

Since the clock is always stepped before the clsf, the only way seems to be catching the exception and outputting it in the handling clock.

This was referenced Mar 11, 2024
@turion
Copy link
Owner Author

turion commented Mar 13, 2024

Reduce redundancy between IO errors and ExceptT

It may make sense to benchmark this somehow. See also https://github.com/turion/rhine/pull/285/files#r1523014312.

@turion turion force-pushed the dev_catch branch 2 times, most recently from 135d3df to ced9d41 Compare March 13, 2024 15:02
@turion turion marked this pull request as ready for review March 13, 2024 15:03
rhine/src/FRP/Rhine/Clock.hs Outdated Show resolved Hide resolved
rhine/test/Clock/Except.hs Outdated Show resolved Hide resolved
rhine/test/Clock/Except.hs Outdated Show resolved Hide resolved
rhine/test/Clock/Except.hs Outdated Show resolved Hide resolved
@turion turion enabled auto-merge March 26, 2024 13:56
@turion turion merged commit 9b06f58 into master Mar 26, 2024
8 of 9 checks passed
@turion turion deleted the dev_catch branch March 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant