feat(table): add aws_rds_db_maintenance_action

[fyqtian]

Integration test logs

Logs

Add passing integration test logs here

Example query results

Results

 resource_identifier                                                                 | action        | opt_in_status | auto_applied_after_date | current_apply_date | description                                     | forced_apply_date | tags   | title                             >
+-------------------------------------------------------------------------------------+---------------+---------------+-------------------------+--------------------+-------------------------------------------------+-------------------+--------+----------------------------------->
| arn:aws:rds:us-west-2:000000000000:cluster:cluster1                                 | system-update | <null>        | <null>                  | <null>             | Upgrade to Aurora PostgreSQL 15.5.6             | <null>            | <null> | arn:aws:rds:us-west-2:000000000000>
| arn:aws:rds:us-west-2:000000000000:db:db1                                           | system-update | <null>        | <null>                  | <null>             | New Operating System patch is available         | <null>            | <null> | arn:aws:rds:us-west-2:000000000000>
| arn:aws:rds:us-west-2:000000000000:cluster:cluster1                                 | os-upgrade    | <null>        | <null>                  | <null>             | New Operating System patch is available         | <null>            | <null> | arn:aws:rds:us-west-2:000000000000>
| arn:aws:rds:us-west-2:000000000000:db:db2                                           | system-update | <null>        | <null>                  | <null>             | New Operating System patch is available         | <null>            | <null> | arn:aws:rds:us-west-2:000000000000>
| arn:aws:rds:us-west-2:000000000000:db:db3                                           | db-upgrade    | <null>        | <null>                  | <null>             | New engine patch version is available: 13.15.R3 | <null>            | <null> | arn:aws:rds:us-west-2:000000000000>
| arn:aws:rds:us-west-2:000000000000:cluster:cluster1                                 | system-update | <null>        | <null>                  | <null>             | Upgrade to Aurora PostgreSQL 14.11.4            | <null>            | <null> | arn:aws:rds:us-west-2:000000000000

[ParthaI]

Hello @fyqtian, I’ve added a few initial review comments. When you get a chance, could you please take a look?

Additionally, it would be great to include more example queries in the documentation.

[fyqtian]

Hello @ParthaI
I wanted to take a moment to express my sincere gratitude for the valuable guidance you provided on my recent pull request. Your insights and suggestions were incredibly helpful and have significantly improved the quality of my work.

I appreciate the time you took to review my code and offer constructive feedback. Your expertise has not only enhanced my understanding of the project but also motivated me to strive for better practices in my future contributions.

Thank you once again for your support. I look forward to implementing your suggestions and continuing to learn from you.

[ParthaI]

Hello @fyqtian,

I’ve provided another set of review comments. Please take a look when you have a moment.

Additionally, I would appreciate it if you could review the following:

• Consider updating the table name to aws_rds_pending_maintenance_action for better clarity based on the API name.
• Fix indentation, casing, title, and description in the queries.
• Ensure the queries are available in both SQLite and PostgreSQL formats as we have for other tables.
• If possible, please add an example query demonstrating a table join.

Thank you! 😊

[ParthaI]

Hi @fyqtian,

I'm not sure if all the changes have been pushed yet. Could you please review the following points?

• Update the table and file name to aws_rds_pending_maintenance_action (we should always use the singular form).
• In the documentation, I noticed that reserved PostgreSQL keywords (e.g., SELECT, FROM, WHERE, CASE) are in uppercase. Please convert them to lowercase to maintain consistency with other table documentation.
• Update the query title "Show if the maintenance action is for a cluster" to "Check if a maintenance action is for a cluster" for better readability.
• Ensure that the query is provided in both SQLite and PostgreSQL formats.
• Please include an example query demonstrating how to join this table with aws_rds_db_instance and aws_rds_db_cluster. This will help users understand how this table can be used in combination with other tables.

Let me know if you need any clarification. Thanks!

[fyqtian]

"Hi @ParthaI, I apologize for my carelessness. I often struggle to adhere to standards, and I recognize this as a personal shortcoming. Thank you once again for your time and effort in handling this tedious work; it greatly encourages me to engage with the community.

[fyqtian]

As you mentioned "Please include an example query demonstrating how to join this table with aws_rds_db_instance and aws_rds_db_cluster. This will help users understand how this table can be used in combination with other tables."

I noticed that the aws_rds_db_cluster table has pending_maintenance_actions field and I think it is not necessary to write a join sql.

select pending_maintenance_actions from aws_rds_db_cluster where pending_maintenance_actions is not null;

[ParthaI]

I noticed that the aws_rds_db_cluster table has pending_maintenance_actions field and I think it is not necessary to write a join sql.

Yes, I have noticed it. The tables aws_rds_db_instance and aws_rds_db_cluster already include columns to retrieve this information. However, the API implementation lacks pagination support, which means that if there are more than 100 pending maintenance actions, the results will be incomplete.

Based on our table development standards, we could consider adding a separate table if the API supports pagination to fetch the complete dataset. Once the new table is implemented and merged into the main branch, we will deprecate the respective columns in aws_rds_db_instance and aws_rds_db_cluster. The deprecation will take effect in the next release to ensure a smooth transition.

[ParthaI]

Hi @fyqtian,

I wanted to bring to your attention on a comment regarding the table naming in this pull request. You can find the specific feedback here: #2430 (review). Could you please review and address this?

Thank you!

[fyqtian]

Hi @ParthaI, after updating the files' names and related references, please confirm. Thank you