Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved InvalidParameterException in aws_ecs_service table when listing tags for older services. Closes #2388 #2410

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Resolved InvalidParameterException in aws_ecs_service table when listing tags for older services. Closes #2388 #2410

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f50a03
Resolved `InvalidParameterException` in `aws_ecs_service` table when …
ParthaI Feb 11, 2025
9fedb7b
Update the logic to make the long arn format by hand instead of igno…
ParthaI Feb 19, 2025
3d0278a
Update the list function to make the Get Cluster API call
ParthaI Feb 19, 2025
ef53852
Update the Get Cluster API call to be happen under the getEcsServiceTags
ParthaI Feb 19, 2025
681a1a3
Update the comment with better clarification
ParthaI Feb 19, 2025
b5564a5
Handle InvalidParameterException for older ARN format of service
ParthaI Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions aws/table_aws_ecs_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ package aws

import (
"context"
"errors"
"sync"

"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/ecs"
"github.com/aws/aws-sdk-go-v2/service/ecs/types"
"github.com/aws/smithy-go"

ecsv1 "github.com/aws/aws-sdk-go/service/ecs"

Expand Down Expand Up @@ -351,6 +353,20 @@ func getEcsServiceTags(ctx context.Context, d *plugin.QueryData, h *plugin.Hydra

response, err := svc.ListTagsForResource(ctx, params)
if err != nil {
// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html#ecs-resource-ids
// We can have two arn format for the ESC Service:
// 1. arn:aws:ecs:<region>:<account_id>:service/<cluster_name>/<service_name> (Newer format)
// 2. arn:aws:ecs:<region>:<account_id>:service/<service_name> (Older format)
// While making the API with older service arn we are encountering the error:
// ERROR: rpc error: code = Unknown desc = my_aws_account: table 'aws_ecs_service' column 'tags' requires hydrate data from getEcsServiceTags,
// which failed with error operation error ECS: ListTagsForResource, https response error StatusCode: 400,
// RequestID: 076ed52f-8f0e-43b9-af89-3728995bb52b, InvalidParameterException: Long arn format must be used for tagging operations.
var ae smithy.APIError
if errors.As(err, &ae) {
if ae.ErrorCode() == "InvalidParameterException" {
return nil, nil
}
}
plugin.Logger(ctx).Error("aws_ecs_service.getEcsServiceTags", "api_error", err)
return nil, err
}
Expand Down
Loading