Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column scheduled_actions to aws_ec2_autoscaling_group #2062

Closed

Conversation

keyolk
Copy link
Contributor

@keyolk keyolk commented Jan 25, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
SELECT 
    jsonb_array_elements(policies)->>'Enabled' AS enabled
FROM 
    aws_ec2_autoscaling_group
LIMIT 1
+---------+
| enabled |
+---------+
| true    |
+---------+

@misraved misraved self-requested a review February 6, 2024 13:28
@misraved
Copy link
Contributor

misraved commented Feb 6, 2024

Thank you for the PR @keyolk, however, our plugin table architecture leans on creating new tables for API calls that have a paginated response.

In this case, the ideal solution would be to create a new table called aws_appautoscaling_scheduled_action as mentioned in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appautoscaling_scheduled_action.

Please let us know if you have questions, happy to provide input and discussions around creating the new table 👍.

@misraved misraved closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants