Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS libraries #2039

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

Zlender
Copy link

@Zlender Zlender commented Jan 3, 2024

This is in response to comment #2035. My go skills are basic so if I made a silly mistake or went against standard way of doing it let me know.

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@Zlender
Copy link
Author

Zlender commented Jan 3, 2024

This currently does not compile. It looks like 1.4.0 version of securitylake library removes GetDatalake api call aws/aws-sdk-go-v2@c682766

@Zlender Zlender mentioned this pull request Jan 3, 2024
@Zlender
Copy link
Author

Zlender commented Jan 3, 2024

Found https://docs.aws.amazon.com/security-lake/latest/APIReference/API_ListDataLakes.html . It compiles now but likely doesn't work correctly yet.

@misraved misraved requested a review from bigdatasourav January 5, 2024 07:59
@bigdatasourav
Copy link
Contributor

Hey @Zlender, Could you please resolve the conflicts?

@Zlender Zlender force-pushed the aws_version_updates branch from f4a9170 to aa68bc6 Compare February 1, 2024 14:52
@Zlender
Copy link
Author

Zlender commented Feb 1, 2024

@bigdatasourav done

@misraved misraved changed the base branch from main to add-eks-insights-table February 8, 2024 13:25
@misraved misraved merged commit ceb1a10 into turbot:add-eks-insights-table Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants