Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table aws_servicecatalog_provisioned_product. Closes #1889. #1917

Merged
merged 13 commits into from
Jan 16, 2024

Conversation

madhushreeray30
Copy link
Contributor

@madhushreeray30 madhushreeray30 commented Sep 28, 2023

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
select
  name,
  id,
  arn,
  type,
  product_id,
  created_time,
  last_provisioning_record_id
from
  aws_servicecatalog_provisioned_product;

+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+
| name                  | id               | arn                                                                                        | type      | product_id         | created_time              | last_provisioning_record_id |
+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+
| provisioned-prod-test | pp-o62ffd6n5y2lm | arn:aws:servicecatalog:us-east-1:111111111111:stack/provisioned-prod-test/pp-o62ffd6n5y2lm | CFN_STACK | prod-hllga44jzyfou | 2023-09-28T10:42:34+05:30 | rec-knmtxjurw7o4s           |
+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+
select
  name,
  id,
  arn,
  type,
  product_id,
  created_time,
  last_provisioning_record_id
from
  aws_servicecatalog_provisioned_product 
where 
  id = 'pp-o62ffd6n5y2lm';

+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+
| name                  | id               | arn                                                                                        | type      | product_id         | created_time              | last_provisioning_record_id |
+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+
| provisioned-prod-test | pp-o62ffd6n5y2lm | arn:aws:servicecatalog:us-east-1:111111111111:stack/provisioned-prod-test/pp-o62ffd6n5y2lm | CFN_STACK | prod-hllga44jzyfou | 2023-09-28T10:42:34+05:30 | rec-knmtxjurw7o4s           |
+-----------------------+------------------+--------------------------------------------------------------------------------------------+-----------+--------------------+---------------------------+-----------------------------+

@madhushreeray30 madhushreeray30 self-assigned this Sep 28, 2023
@madhushreeray30 madhushreeray30 linked an issue Sep 28, 2023 that may be closed by this pull request
@misraved misraved requested a review from ParthaI September 28, 2023 18:01
Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhushreeray30, I have left a few review comments. Please take a look, Thanks!

Also, could you please add the integration test for this table? I believe the resource is supported by terraform
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/servicecatalog_provisioned_product

where
type = 'CFN_STACK'
and last_successful_provisioning_record_id is not null;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include example queries that use the search_query in the WHERE clause to provide a clearer understanding of how to use this optional qualifier for result filtering.

e.g:

@madhushreeray30
Copy link
Contributor Author

@madhushreeray30, I have left a few review comments. Please take a look, Thanks!

Also, could you please add the integration test for this table? I believe the resource is supported by terraform https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/servicecatalog_provisioned_product

As this is an external issue I think we can go ahead without the integration tests for now.

@ParthaI
Copy link
Contributor

ParthaI commented Jan 12, 2024

@madhushreeray30, I have left a few review comments. Please take a look, Thanks!
Also, could you please add the integration test for this table? I believe the resource is supported by terraform https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/servicecatalog_provisioned_product

As this is an external issue I think we can go ahead without the integration tests for now.

We can not have a integration test suit for it, AWS removed the support for the PROVISIONED PRODUCT. Doc Link: https://docs.aws.amazon.com/servicecatalog/latest/adminguide/update_terraform_open_source_to_external.html

Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigdatasourav bigdatasourav merged commit adc67b4 into main Jan 16, 2024
1 check passed
@bigdatasourav bigdatasourav deleted the issue1889 branch January 16, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table aws_servicecatalog_provisioned_product
3 participants