-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table aws_servicecatalog_provisioned_product
. Closes #1889.
#1917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhushreeray30, I have left a few review comments. Please take a look, Thanks!
Also, could you please add the integration test for this table? I believe the resource is supported by terraform
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/servicecatalog_provisioned_product
where | ||
type = 'CFN_STACK' | ||
and last_successful_provisioning_record_id is not null; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include example queries that use the search_query in the WHERE clause to provide a clearer understanding of how to use this optional qualifier for result filtering.
e.g:
## Filter examples |
As this is an external issue I think we can go ahead without the integration tests for now. |
We can not have a integration test suit for it, AWS removed the support for the PROVISIONED PRODUCT. Doc Link: https://docs.aws.amazon.com/servicecatalog/latest/adminguide/update_terraform_open_source_to_external.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Integration test logs
Logs
Example query results
Results