Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table aws_organizations_organizational_unit and aws_organizations_root. closes #1674 #1677
Add table aws_organizations_organizational_unit and aws_organizations_root. closes #1674 #1677
Changes from 3 commits
552c852
28fe36b
f01e018
a296915
14cc4db
9598dfb
f0a48bc
7202314
c2a3aac
e798034
65e3f8f
f3b04df
1767e84
81be37d
b6ee130
5c8bff5
aa9ba27
787f320
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your second example in this ticket does not specify
parent_id
, how come it worked?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the table definition we have two config one is List Config and another one is Get Config.
In List config we generally make list API call and in Get config we make the get API call.
Here we are using ListAccountsForParent API in the
List config
, for making theListAccountsForParent
API call we must need to pass theParentId
in param of this API call, soparent_id
is required to make list API call.In Get config we are using the DescribeOrganizationalUnit API call, for making this API call we must have to pass the
OrganizationalUnitId
, we do not needParentId
for this API call.The Get API will be called if we are providing
id
as query parameter, so in second example we need to pass theparent_id
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it for the logic underneath ; may I suggest a working like this?
I found similar wording/format for aws_route53_record, aws_iam_access_advisor, aws_cloudtrail_trail_event and others
Also from a user perspective I find it odd that we can't have the listing without a parent_id, but looking at API reference it looks tricky to get the root id reliably...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah @ajoga, this looks better, will push the changes. Thanks!