Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table aws_rds_db_maintenance_actions #2413

Open
cosmos-sun opened this issue Feb 14, 2025 · 6 comments · Fixed by #2430 · May be fixed by #2439
Open

Add table aws_rds_db_maintenance_actions #2413

cosmos-sun opened this issue Feb 14, 2025 · 6 comments · Fixed by #2430 · May be fixed by #2439
Assignees
@fyqtian
Labels
enhancement New feature or request help wanted We are asking the community to submit a PR to resolve this issue new table New table request

Comments

@cosmos-sun
Copy link

References
Add any related links that will help us understand the resource, including vendor documentation, related GitHub issues, and Go SDK documentation.

API Document: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribePendingMaintenanceActions.html
CLI Document: https://docs.aws.amazon.com/cli/latest/reference/rds/describe-pending-maintenance-actions.html
@cosmos-sun cosmos-sun added enhancement New feature or request new table New table request labels Feb 14, 2025
@cosmos-sun cosmos-sun changed the title Add table aws_rds_db_describe_maintenance Add table aws_rds_db_maintenance_actions Feb 14, 2025
@misraved misraved added the help wanted We are asking the community to submit a PR to resolve this issue label Feb 17, 2025
@misraved
Copy link
Contributor

misraved commented Feb 17, 2025 •
edited
Loading

Thanks @cosmos-sun for raising this issue!!

If anyone would like to attempt to develop this table, the API documentation mentioned by @cosmos-sun is an excellent place to start.

How You Can Help

  • Review the issue details and suggested approach (if provided).
  • Comment below if you're interested in working on it or if you have any questions.
  • If you decide to take this on, feel free to open a PR when you're ready!

💡 Need Guidance?
We're happy to provide context, feedback, and support as you work through the issue. Don't hesitate to ask questions!

@fyqtian
Copy link

fyqtian commented Feb 23, 2025

Hello @misraved, I would like to take this task.

@ParthaI
Copy link
Contributor

ParthaI commented Feb 24, 2025

Thanks for your interest, @fyqtian! I've assigned the issue to you—feel free to reach out if you need any help.

@fyqtian
Copy link

fyqtian commented Feb 24, 2025 •
edited
Loading

Hi @ParthaI, Thank you for your kindness.
I created a new table and ran it in my local environment, but the error confused me.
Is there any thing I should take care?

Copy the code new table from aws_rds_db_cluster

> select db_cluster_identifier from aws_rds_db_cluster;
+---------------------------+
| db_cluster_identifier     |
+---------------------------+
| db1 |
| db2    |
+---------------------------+
> select * from aws_rds_db_maintenance_action;

Error: aws: getClientForQuerySupportedRegion called without a region in QueryData (SQLSTATE HV000)

+---------------------+--------+---------------+-------------------------+--------------------+-------------+-------------------+--------------------+--------+------+
| resource_identifier | action | opt_in_status | auto_applied_after_date | current_apply_date | description | forced_apply_date | sp_connection_name | sp_ctx | _ctx |
+---------------------+--------+---------------+-------------------------+--------------------+-------------+-------------------+--------------------+--------+------+
+---------------------+--------+---------------+-------------------------+--------------------+-------------+-------------------+--------------------+--------+------+

plugin error log

2025-02-24 08:09:07.189 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: in RDSClient: region=""
2025-02-24 08:09:07.189 UTC [ERROR] steampipe-plugin-aws.plugin: [ERROR] 1740384547954: aws_rds_db_maintenance_action.: connection_error="getClientForQuerySupportedRegion called without a region in QueryData"
2025-02-24 08:09:07.189 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: doList callHydrateWithRetries (aws-1740384547954) returned err getClientForQuerySupportedRegion called without a region in QueryData
2025-02-24 08:09:07.189 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: QueryData StreamError getClientForQuerySupportedRegion called without a region in QueryData (aws-1740384547954)
2025-02-24 08:09:07.189 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: streamRows execution has failed: aws-1740384547954 - calling queryCache.AbortSet (aws: getClientForQuerySupportedRegion called without a region in QueryData)
2025-02-24 08:09:07.190 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: QueryCache AbortSet - aborting request  with error aws: getClientForQuerySupportedRegion called without a region in QueryData (1 subscriber) (aws-1740384547954)
2025-02-24 08:09:07.190 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: queryData.streamRows returned error: aws: getClientForQuerySupportedRegion called without a region in QueryData
2025-02-24 08:09:07.190 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: executeForConnection aws returned error aws: getClientForQuerySupportedRegion called without a region in QueryData, writing to CHAN
2025-02-24 08:09:07.190 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: readAndStreamAsync failed to read previous rows from cache: aws: getClientForQuerySupportedRegion called without a region in QueryData publisher aws-1740384547954 (aws-1740384547954)
2025-02-24 08:09:07.190 UTC [WARN]  steampipe-plugin-aws.plugin: [WARN]  1740384547954: error channel received aws: getClientForQuerySupportedRegion called without a region in QueryData

@ParthaI
Copy link
Contributor

ParthaI commented Feb 24, 2025

Hello @fyqtian,

It looks like the build region matrix function is missing here.

Since this resource is regional, specifying the region is necessary when creating the client.

For reference, you can check a similar implementation in aws_acm_certificate.

Please let me know if you need any further help! Thanks!😊

@fyqtian
Copy link

fyqtian commented Feb 25, 2025 •
edited
Loading

Hi @ParthaI
It’s working now that you pointed out the key point.
Please review the pr
Let me know if there is anything that needs to be updated.

This was linked to pull requests Feb 25, 2025
feat(table): add aws_rds_db_maintenance_action #2430
Merged
feat(table): add aws_rds_pending_maintenance_action (#2430) #2439
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyqtian fyqtian

Labels
enhancement New feature or request help wanted We are asking the community to submit a PR to resolve this issue new table New table request
Projects
None yet
Milestone
No milestone
4 participants
@cosmos-sun @fyqtian @misraved @ParthaI