Skip to content

Commit

Permalink
Fix typo integration test failure
Browse files Browse the repository at this point in the history
  • Loading branch information
ParthaI committed Feb 10, 2025
1 parent 955abe4 commit e69b002
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
2 changes: 1 addition & 1 deletion aws-test/tests/aws_iot_thing/test-notfound-expected.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
Original file line number Diff line number Diff line change
@@ -1 +1 @@
null
[]
8 changes: 8 additions & 0 deletions aws/table_aws_kinesis_consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ package aws

import (
"context"
"errors"

"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/kinesis"
"github.com/aws/aws-sdk-go-v2/service/kinesis/types"
"github.com/aws/smithy-go"

kinesisv1 "github.com/aws/aws-sdk-go/service/kinesis"

Expand Down Expand Up @@ -141,6 +143,12 @@ func listKinesisConsumers(ctx context.Context, d *plugin.QueryData, h *plugin.Hy

output, err := paginator.NextPage(ctx)
if err != nil {
var ae smithy.APIError
if errors.As(err, &ae) {
if ae.ErrorCode() == "ResourceNotFoundException" {
return nil, nil
}
}
plugin.Logger(ctx).Error("aws_kinesis_consumer.listKinesisConsumers", "api_error", err)
return nil, err
}
Expand Down
3 changes: 3 additions & 0 deletions aws/table_aws_lightsail_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ func tableAwsLightsailInstance(_ context.Context) *plugin.Table {
List: &plugin.ListConfig{
Hydrate: listLightsailInstances,
Tags: map[string]string{"service": "lightsail", "action": "GetInstances"},
IgnoreConfig: &plugin.IgnoreConfig{
ShouldIgnoreErrorFunc: shouldIgnoreErrors([]string{"NotFoundException"}),
},
},
HydrateConfig: []plugin.HydrateConfig{
{
Expand Down

0 comments on commit e69b002

Please sign in to comment.