Hearing post put #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuomas777
reviewed
Nov 24, 2016
| @@ -80,6 +80,12 @@ def default_hearing(john_doe, contact_person): | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| def default_label(): | |||
| label = Label.objects.create(id=1, label='The Label') | |||
There was a problem hiding this comment.
Setting an id explicitly here probably isn't a good idea as it might lead to collisions afterwards
| assert_hearing_equals(data, valid_hearing_json, john_smith_api_client.user) | ||
|
|
||
|
|
||
| # Test that a user can update a hearing |
There was a problem hiding this comment.
This comment doesn't really seem to match the test? :)
| assert data == {'status': 'User without organization cannot PUT hearings.'} | ||
|
|
||
|
|
||
| # Test that a user can update a hearing |
| "servicemap_url": "url", | ||
| }) | ||
| data['sections'][0]['title'] = 'First section' | ||
| data['sections'][1]['images'][0]['caption'] = 'New image caption' |
There was a problem hiding this comment.
Is this change actually verified somewhere?
| hearing = create_hearings(1)[0] | ||
| response = john_smith_api_client.post(endpoint, data=valid_hearing_json, format='json') | ||
| data = get_data_from_response(response, status_code=201) | ||
| data['sections'][0]['id'] = hearing.id |
There was a problem hiding this comment.
Would be a bit better, if the id was actually from an existing section id from another hearing
| return Response(serializer.data) | ||
| return response.Response(serializer.data) | ||
|
|
||
| def create(self, request, pk=None): |
There was a problem hiding this comment.
I think create() will never get param pk
added 8 commits
November 25, 2016 12:10
Add a function _create_or_update_sections Use this function in both create and update
Only users from the same organization can update a hearing Remove duplicated import Response Expand Organization upon deserializing created/updated hearing Return 'created_at' when deserializing created/updated hearing Assign Organization while POSTing a hearing
Move the test_image into tests/utils.py Add a function image_test_json which returns this image Update the test_comment to use this function
stephawe
force-pushed
the
hearing-post-put
branch
from
c4ce12f to
ee1610d
Compare
stephawe
force-pushed
the
hearing-post-put
branch
2 times, most recently
from
2f74051 to
b7bb684
Compare
added 6 commits
November 29, 2016 18:43
Allow to GET unpublished hearings if same organization Add tests
Unpublished Hearing are now visible to users of the same organization Function can now be used for filtering Hearings with hearing_lookup=''
Allow to update partially a Hearing using PATCH Add test
stephawe
force-pushed
the
hearing-post-put
branch
from
b7bb684 to
c94f25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.