-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustment of Doxygen documentation (enable) #536
base: development
Are you sure you want to change the base?
Adjustment of Doxygen documentation (enable) #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree with the problem, I'd fix the other way around - fix the documentation, with a clear instruction, where to turn it on.
Reasoning: building documentation takes quite some time and hinders "build solution" greatly.
This reverts commit 13658ae.
Commit aae0c68 is only an optional suggestion from my side. At the end of the setup process, probably not everyone takes a detailed look into the Doyxgen guidelines. |
@@ -19,23 +19,27 @@ Refer to the [doxygen manual](http://www.doxygen.nl/manual) for everything else. | |||
|
|||
## Doxygen settings in CMake | |||
|
|||
By default, doxygen is disabled. | |||
To enable doxygen, search for the `DOXYGEN_GENERATE_DOCUMENTATION` option in CMake and set the check box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're revisiting this in this PR, I'd propose to prepend the variable with OIP_
so that it is grouped together with other OIP's variables. Please change accordingly everywhere, where it comes up (I assume there are mentions in the Doxygen documentation as well).
Additionally, the following options can be selected: | ||
- `DOXYGEN_INCLUDE_COMMENTED_ONLY` (default = ON): If selected, only the documentation for explicitly commented entities will be generated. Otherwise, doxygen will assume that all entities are documented, even if there is no documentation available. | ||
- `DOXYGEN_INCLUDE_INTERNAL` (default = OFF): If selected, this will include all comments preceded by "\internal". These are comments intended for developers only. So if the generated documentation is intended for external users, this option should not be selected. | ||
- DOXYGEN_INCLUDE_EARLYBINDING (default = OFF): If selected (... and already built), this will include the selected IFC schemas in the documentation. Otherwise, the schemas will not be included in the documentation, but this does not influence the selection of IFC schemas (see EARLYBINDING_ tags in CMake GUI). | ||
- DOXYGEN_AUTO_OPEN_DOCUMENTATION (default = ON): If selected, the landing page of the documentation will automatically open. If not selected, you will have to find and open the generated documentation manually (see section below on building the documentation). | ||
- `DOXYGEN_INCLUDE_EARLYBINDING` (default = OFF): If selected (... and already built), this will include the selected IFC schemas in the documentation. Otherwise, the schemas will not be included in the documentation, but this does not influence the selection of IFC schemas (see EARLYBINDING_ tags in CMake GUI). | ||
- `DOXYGEN_AUTO_OPEN_DOCUMENTATION` (default = ON): If selected, the landing page of the documentation will automatically open. If not selected, you will have to find and open the generated documentation manually (see section below on building the documentation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply here as well (prepend with OIP_
).
@@ -177,6 +177,7 @@ Build the project **OpenInfraPlatform.GenerateDocumentation** within *Commands* | |||
*NOTE:* This step may take quite some time. | |||
|
|||
Read more about Doxygen in our [guidelines](./DoxygenHelp.md). | |||
*NOTE:* Doxygen is disabled by default. See the guidelines for a description how to enable Doxygen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*NOTE:* Doxygen is disabled by default. See the guidelines for a description how to enable Doxygen. | |
*NOTE:* Documentation generation is disabled by default. See the guidelines for a description of how to enable Doxygen. |
Since we're renaming already, I'd call these variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add from my side.
Fixes #535, detailed description with test of the suggested change in the issue.