Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree viewer #429

Draft
wants to merge 21 commits into
base: development
Choose a base branch
from
Draft

Tree viewer #429

wants to merge 21 commits into from

Conversation

jschlenger
Copy link
Collaborator

Implementation of a viewer that shows the hierarchy tree of IFC files.

@jschlenger jschlenger added enhancement New feature or request IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement labels Apr 15, 2021
@jschlenger jschlenger self-assigned this Apr 15, 2021
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely the correct start.

UserInterface/Dialogues/IfcTreeDialog.h Outdated Show resolved Hide resolved
UserInterface/MainWindow.cpp Outdated Show resolved Hide resolved
Comment on lines +1809 to +1816
void OpenInfraPlatform::UserInterface::MainWindow::on_actionShow_Ifc_Tree_triggered() {
if (ifcTreeDialog_ == nullptr) {
ifcTreeDialog_ = new IfcTreeDialog(this);
}

ifcTreeDialog_->show();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know which model was clicked?

Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all comments need addressing - if I'm wrong, merely resolve them.

Core/src/IfcGeometryConverter/IfcImporter.h Outdated Show resolved Hide resolved
UserInterface/Dialogues/IfcTreeDialog.cpp Outdated Show resolved Hide resolved
UserInterface/Dialogues/IfcTreeItem.cpp Outdated Show resolved Hide resolved
UserInterface/Dialogues/IfcTreeItem.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still surprised that this ain't working ...

((QDialog*)this)->show();
if (std::dynamic_pointer_cast<oip::IfcModel>(model))
{
auto ifcModel = std::static_pointer_cast<OpenInfraPlatform::Core::IfcGeometryConverter::IfcModel>(model);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use dynamic pointer cast as well

Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Lots of commented out code, should be addressed before the final merge.

@jschlenger
Copy link
Collaborator Author

Current status:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request IFC Content related to Industry Foundation Classes (IFC) functionalities quality_of_life Nice to have improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants