fix: 全角英数を半角英数に置き換える #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5 Add functionality to replace full-width alphanumeric characters with half-width ones in specified fields. * **src/lib/string.ts**: Add a utility function `replaceFullWidthWithHalfWidth` to replace full-width alphanumeric characters with half-width ones. * **src/store/data.ts**: Import `replaceFullWidthWithHalfWidth` from `src/lib/string.ts`. Update the `transactions` computed property to use `replaceFullWidthWithHalfWidth` for the specified fields: receipt number and total number of nights stayed. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tsukuba-neu/sawagani/issues/5?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/store/data.ts:120
- Ensure that the new behavior of replacing full-width alphanumeric characters with half-width ones in the 'receipt' field is covered by tests.
receipt: replaceFullWidthWithHalfWidth(row[header.indexOf('領収書No')]),
src/store/data.ts:125
- Ensure that the new behavior of replacing full-width alphanumeric characters with half-width ones in the 'numStay' field is covered by tests.
numStay: replaceFullWidthWithHalfWidth(row[header.indexOf('延べ宿泊数')]),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Add functionality to replace full-width alphanumeric characters with half-width ones in specified fields.
replaceFullWidthWithHalfWidthto replace full-width alphanumeric characters with half-width ones.replaceFullWidthWithHalfWidthfromsrc/lib/string.ts. Update thetransactionscomputed property to usereplaceFullWidthWithHalfWidthfor the specified fields: receipt number and total number of nights stayed.For more details, open the Copilot Workspace session.