-
-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html: Add Unicode 11 xterm.js addon #1310
Conversation
@tsl0922 Will need some advice on how I activated the feature. Not sure I activated it in the preferred location. Feel free to recommend any changes or improvements. For reference this is the line I am uncertain about: terminal.unicode.activeVersion = '11'; |
Maybe it can be a Client Option, if we want to extend it to support unicode-graphemes addon later. |
I think once the The reason I didn't make Unicode 11 an option was I can't think of why you wouldn't want this always enabled. What benefit do we gain from this being an option? Without this being set, most emoji are just rendered incorrectly. |
You can enable / disable this addon, or switch to |
Does this mean we want something that has a value of |
You actually have me thinking, should we add |
The value should be valid for
No, |
So let me clarify this before I get started:
This is slightly different to your earlier post but I think it makes more sense to have Unicode 11 as the default. Unicode 6 is just way too old and renders very differently. Happy to adjust this logic though based on your feedback. |
We don't need to handle values for |
Add Unicode 11 addon to xterm.js to enable support for newer Unicode standards. This addon significantly improves rendering of emojis. Signed-off-by: Michael Lorant <[email protected]>
Thanks for merging this! 🤞 when this is released there are no issues. |
Add Unicode 11 addon to xterm.js to enable support for newer Unicode standards. This addon significantly improves rendering of emojis.