Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember: set verbatimModuleSyntax: true #230

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

This is a breaking change for consumers of @tsconfig/ember, as they'll receive errors if they were not previously enforcing import type for type-imports.

Context:

The problem being solved here:

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@chriskrycho chriskrycho enabled auto-merge October 26, 2023 13:59
@chriskrycho chriskrycho merged commit b9e1a07 into tsconfig:main Oct 26, 2023
1 check passed
@chriskrycho
Copy link
Contributor

Note for @orta: since I have stepped back and am much less active, I have given two other members of the official Ember TypeScript team the write permissions so they can merge changes here, so folks in that ecosystem stay unblocked!

@NullVoxPopuli NullVoxPopuli deleted the patch-1 branch October 26, 2023 14:37
@orta
Copy link
Member

orta commented Oct 26, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants