-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Added skeleton loaders to Credentials Page #1745
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1745 +/- ##
=======================================
Coverage 87.16% 87.16%
=======================================
Files 12 12
Lines 1356 1356
=======================================
Hits 1182 1182
Misses 104 104
Partials 70 70 Continue to review full report at Codecov.
|
Nice progress! There is one thing I noticed on the first video - the loading state seems to turn off a bit too early. You can see that the default vault shows up right after the skeletons disappear, but the rest of the vaults still take time to show up. Could you investigate this, please? @HeidiHan0000 |
<div class="flex flex-col justify-start items-start px-0 w-full"> | ||
<div | ||
class="flex z-10 flex-row justify-between items-center lg:py-6 pr-8 pl-5 w-full lg:h-24 bg-neutrals-whiteLilac rounded-xl" | ||
:class="isTall ? 'h-24 py-6' : 'h-20 py-5'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this isTall defined ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defined it as a prop, set to false
by default and passed in true
for the Credential Details Page. On the Credential Details Page, isTall
is true
for any screen size. On the Credentials Page, isTall
is only true
for large screens (this is based on the designs)
Signed-off-by: heidihan0000 <[email protected]>
Comment from design team: Created #1746 to address this |
Screen.Recording.2022-06-24.at.4.49.14.PM.mov
Vaults Page:
Screen.Recording.2022-06-24.at.12.00.29.PM.mov
Screen.Recording.2022-06-24.at.12.01.50.PM.mov
Credentials Page:
Screen.Recording.2022-06-24.at.12.04.51.PM.mov
Screen.Recording.2022-06-24.at.12.03.38.PM.mov
Signed-off-by: heidihan0000 [email protected]