Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: Added skeleton loaders to Credentials Page #1745

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

HeidiHan0000
Copy link
Contributor

@HeidiHan0000 HeidiHan0000 commented Jun 24, 2022

Screen.Recording.2022-06-24.at.4.49.14.PM.mov



Vaults Page:

Screen.Recording.2022-06-24.at.12.00.29.PM.mov
Screen.Recording.2022-06-24.at.12.01.50.PM.mov



Credentials Page:

Screen.Recording.2022-06-24.at.12.04.51.PM.mov
Screen.Recording.2022-06-24.at.12.03.38.PM.mov

Signed-off-by: heidihan0000 [email protected]

@HeidiHan0000 HeidiHan0000 added type: enhancement New feature or request area: UI Something related to UI labels Jun 24, 2022
@HeidiHan0000 HeidiHan0000 self-assigned this Jun 24, 2022
@cla-bot cla-bot bot added the cla-signed label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1745 (1e1f276) into main (866df70) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          12       12           
  Lines        1356     1356           
=======================================
  Hits         1182     1182           
  Misses        104      104           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866df70...1e1f276. Read the comment docs.

@birtony
Copy link
Contributor

birtony commented Jun 24, 2022

Nice progress! There is one thing I noticed on the first video - the loading state seems to turn off a bit too early. You can see that the default vault shows up right after the skeletons disappear, but the rest of the vaults still take time to show up. Could you investigate this, please? @HeidiHan0000

<div class="flex flex-col justify-start items-start px-0 w-full">
<div
class="flex z-10 flex-row justify-between items-center lg:py-6 pr-8 pl-5 w-full lg:h-24 bg-neutrals-whiteLilac rounded-xl"
:class="isTall ? 'h-24 py-6' : 'h-20 py-5'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this isTall defined ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defined it as a prop, set to false by default and passed in true for the Credential Details Page. On the Credential Details Page, isTall is true for any screen size. On the Credentials Page, isTall is only true for large screens (this is based on the designs)

@HeidiHan0000
Copy link
Contributor Author

HeidiHan0000 commented Jun 24, 2022

Comment from design team:
"Lots of loaders going on for data that hasn’t changed, this causes a very clunky and “slow” feeling experience.
Data that hasn't changed (vault cards, credential cards...) should be cached and should be quick to load."

Created #1746 to address this

@rolsonquadras rolsonquadras merged commit c573c0d into trustbloc:main Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: UI Something related to UI cla-signed type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement loading skeleton for vaults filter flyout Update skeleton loaders for credential preview cards
4 participants