feat: updates for USWDS v3.7 #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlenz
changed the title
|
Made feat since we want this to show in the changelog |
|
Added |
brandonlenz
reviewed
Dec 28, 2023
Comment on lines
+135
to
+136
| <span aria-hidden="true">An</span> | ||
| {` official website of the `} |
There was a problem hiding this comment.
Yay no more screen reader Unofficial vs An official silliness!
brandonlenz
requested changes
Dec 28, 2023
brandonlenz
reviewed
Dec 28, 2023
brandonlenz
approved these changes
Dec 28, 2023
|
Thanks for making those changes!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2682
The following changes in the 3.7 and 3.7.1 updates involved more than just scss updates. Changes that are checked off have been committed to this PR; the others are available for others to contribute updates to (or remove if no update is needed):
USWDS - Banner: Allow banner to init without accordion requirement uswds/uswds#5551edit: this one was actually a USWDS-specific implementation change, no change needed for us
edit: this was also a USWDS-specific refactor, but I did add the console errors from here
Related Issues or PRs
How To Test
Screenshots (optional)