fix app.trunk.io links #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make all flaky test links have the correct flaky+tests intent make all code quality links have the correct code+quality intent
gewenyu99
reviewed
Nov 15, 2024
| @@ -8,7 +8,7 @@ Minimal set up is required to get started with Trunk Merge Queue, as it syncs wi | |||
|
|
|||
| ### Connect your Trunk Organization to GitHub | |||
|
|
|||
| Sign up at [app.trunk.io](https://app.trunk.io/signup?intent=merge\&tr\_s=mergesetup\&tr\_l=1), create a Trunk organization, and connect it to your GitHub repositories. If your repository is already connected to your Trunk organization, you can skip this step. | |||
| Sign up at [app.trunk.io](https://app.trunk.io/signup?intent=merge&tr_s=mergesetup&tr_l=1), create a Trunk organization, and connect it to your GitHub repositories. If your repository is already connected to your Trunk organization, you can skip this step. | |||
There was a problem hiding this comment.
Is this correct? Have to checked with Phil?
There was a problem hiding this comment.
Okay I think this doesn't work.
There was a problem hiding this comment.
I think they are old tracking links for marketing.
|
@joshmarinacci Here's what I think we can do for now:
Maybe we should have login in all links? |
gewenyu99
approved these changes
Nov 18, 2024
gewenyu99
reviewed
Nov 18, 2024
gewenyu99
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make app links to app.trunk.io be https
make all flaky test links have the correct flaky+tests intent
make all code quality links have the correct code+quality intent