Experimental PR #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues detected by flake8: 4 E275 missing whitespace after keyword 1 E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` 6 F401 'random' imported but unused 5 F841 local variable 'biv2' is assigned to but never used
* scipy.e is deprecated, use numpy.e instead see scipy/scipy@6e207a1 * Migrate to the latest github actions * Replace the unsupported python 3.5 with 3.8 * Use python 3.11 instead of 3.8, and 3.12 instead of 3.9
Remove leftovers from python 2 compatibility Co-authored-by: Eric Wieser <[email protected]>
Done by avoid the numpy.result_type (not supported by numba). Instead do the array multiplication at-once, then use the result dtype. This requires some numpy array-indexing tricks.
The test_function_cache is rewritten to use @njit, which may not make much sense for particular test.
In various `__repr__()` implementations, replace 'list(ndarray)' with 'ndarray.tolist()', in order to avoid inclusion of type information (like 'np.int64(1)') by the latest numpy version. This also fixes test_clifford.TestPrettyRepr and test_transformations pytest-s, as they rely on hardcoded results from IPython.lib.pretty. Note: numpy>=2.0 is allowed by numba>=0.60.
Replace the deprecated @generated_jit by @njit
Add 'build.os' config value as suggested in readthedocs#11173. Use python 3.9, as it is the latest version that works - needs removal of the 'sphinx' version limit.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental GitHub pull request