Skip to content

Commit

Permalink
CI: Update GitHub workflow
Browse files Browse the repository at this point in the history
* scipy.e is deprecated, use numpy.e instead
  see scipy/scipy@6e207a1
* Migrate to the latest github actions
* Replace the unsupported python 3.5 with 3.8
* Use python 3.11 instead of 3.8, and 3.12 instead of 3.9
  • Loading branch information
trundev committed Dec 8, 2024
1 parent 8732307 commit 1679d9f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 20 deletions.
36 changes: 18 additions & 18 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
python-version: [3.11]
name: "lint | Python ${{ matrix.python-version }}"
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand All @@ -45,37 +45,37 @@ jobs:
matrix:
include:
# fastest jobs first
- python-version: 3.8
- python-version: 3.11
name: without JIT
disable_jit: 1
- python-version: 3.8
- python-version: 3.11
name: doctests
mode: doctests
# really slow job next, so it runs in parallel with the others
- python-version: 3.8
- python-version: 3.11
name: slow tests
mode: very_slow
- python-version: 3.5
name: default
- python-version: 3.8
name: default
- python-version: 3.9
- python-version: 3.11
name: default
- python-version: 3.8
- python-version: 3.12
name: default
- python-version: 3.11
name: conda
conda: true
- python-version: 3.8
- python-version: 3.11
name: benchmarks
mode: bench

name: "build | ${{ matrix.name }} | Python ${{matrix.python-version}}"
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

# python / pip
- name: Set up Python ${{ matrix.python-version }}
if: "!matrix.conda"
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand All @@ -89,7 +89,7 @@ jobs:
# conda
- name: Set up Python ${{ matrix.python-version }} (conda)
if: matrix.conda
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python-version }}
Expand Down Expand Up @@ -146,24 +146,24 @@ jobs:
# if: ${{ always() }}
# with:
# report_paths: 'junit/test-results.xml'
- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v5

deploy:
needs: test
runs-on: ubuntu-latest
name: deploy
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: "Install"
run: |
python -m pip install --upgrade pip;
python -m pip install build
python -m build --sdist --wheel --outdir dist/
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: dist
path: dist
Expand Down
3 changes: 1 addition & 2 deletions clifford/tools/g3c/rotor_estimation.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import random
from scipy import e
import numpy as np
import multiprocessing

Expand Down Expand Up @@ -379,7 +378,7 @@ def cartans_lines(obj_list_a, obj_list_b):
""" Performs the extended cartans algorithm as suggested by Alex Arsenovic """
V_found, rs = cartan(A=obj_list_a, B=obj_list_b)
theta = ((V_found*~V_found)*e1234)(0)
V_found = e**(-theta/2*e123inf)*V_found
V_found = np.e**(-theta/2*e123inf)*V_found
return V_found


Expand Down

0 comments on commit 1679d9f

Please sign in to comment.