Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133574 / 25.04 / Dashboard Widgets | Storage/Pool selection is not up to date (no sync) #11348

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket description.

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 17, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 17, 2025 11:16
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team January 17, 2025 11:16
@bugclerk bugclerk changed the title NAS-133574: Dashboard Widgets | Storage/Pool selection is not up to date (no sync) NAS-133574 / 25.04 / Dashboard Widgets | Storage/Pool selection is not up to date (no sync) Jan 17, 2025
@bugclerk
Copy link
Contributor

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Global store implementation needs more love.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) January 17, 2025 15:01
@AlexKarpov98 AlexKarpov98 merged commit 671e2dc into master Jan 17, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133574 branch January 17, 2025 15:34
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (9e2ddee) to head (3021777).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11348      +/-   ##
==========================================
- Coverage   82.85%   82.83%   -0.03%     
==========================================
  Files        1659     1659              
  Lines       59346    59345       -1     
  Branches     6232     6232              
==========================================
- Hits        49173    49156      -17     
- Misses      10173    10189      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants