Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133477 / 25.04 / Allow adding directory services groups manually #11342

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bvasilenko
Copy link
Contributor

Changes:

Added ability of manual entry into the groups dropdown

Testing:

  1. Prosivion a new machine with HA and Active Directory
  2. Please see ticket for replication steps and expected results

@bvasilenko bvasilenko requested a review from a team as a code owner January 16, 2025 05:05
@bvasilenko bvasilenko requested review from undsoft and removed request for a team January 16, 2025 05:05
@bugclerk bugclerk changed the title NAS-133477: Allow adding directory services groups manually NAS-133477 / 25.04 / Allow adding directory services groups manually Jan 16, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (1db0212) to head (d9a45d2).
Report is 13 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ivilege/privilege-form/privilege-form.component.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11342      +/-   ##
==========================================
+ Coverage   82.74%   82.79%   +0.04%     
==========================================
  Files        1654     1654              
  Lines       59133    59157      +24     
  Branches     6217     6228      +11     
==========================================
+ Hits        48932    48978      +46     
+ Misses      10201    10179      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works well.

@bvasilenko bvasilenko merged commit 9e2ddee into master Jan 17, 2025
9 checks passed
@bvasilenko bvasilenko deleted the NAS-133477 branch January 17, 2025 06:46
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants