Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133564 / 25.04 / Add relevant links to alerts #11341

Merged
merged 3 commits into from
Jan 16, 2025
Merged

NAS-133564 / 25.04 / Add relevant links to alerts #11341

merged 3 commits into from
Jan 16, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 15, 2025

Changes:

Adds links to alerts when possible:

Снимок экрана 2025-01-15 в 17 33 38

Testing:

Some alerts can be created with:

midclt call --job alert.oneshot_create NFSBindAddress "Test"

For others, you may need to use mocks.

Downstream

Affects Reasoning
Documentation Additional optional links in alerts.

@undsoft undsoft requested a review from a team as a code owner January 15, 2025 22:37
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team January 15, 2025 22:37
@bugclerk bugclerk changed the title NAS-133564: Add relevant links to alerts NAS-133564 / 25.04 / Add relevant links to alerts Jan 15, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 98.52217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (aec62a0) to head (9eaead3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nts/ix-form-glossary/ix-form-glossary.component.ts 50.00% 2 Missing ⚠️
...piring-dialog/session-expiring-dialog.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11341      +/-   ##
==========================================
+ Coverage   82.79%   82.86%   +0.06%     
==========================================
  Files        1655     1659       +4     
  Lines       59159    59344     +185     
  Branches     6226     6230       +4     
==========================================
+ Hits        48982    49176     +194     
+ Misses      10177    10168       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart Solution 👏 Good job.
It works just fine.

@undsoft undsoft enabled auto-merge (squash) January 16, 2025 19:00
@undsoft undsoft merged commit d7aa92e into master Jan 16, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133564 branch January 16, 2025 19:32
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants