Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132330 / 25.04 / Update TrueNAS Brand #11318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

denysbutenko
Copy link
Member

Changes:

  • Updated svg files related for TrueNAS logo
  • Used TrueNAS Community Edition for SCALE
  • Used TrueNAS Enterprise for SCALE Enterprise

Testing:

Check affected places for regressions on desktop and mobile.

Downstream

Affects Reasoning
Documentation New branding, all screenshots needs to be updated

@denysbutenko denysbutenko requested a review from a team as a code owner January 9, 2025 15:49
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team January 9, 2025 15:49
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

@bugclerk bugclerk changed the title Nas 132330 NAS-132330 / 25.04 / Nas 132330 Jan 9, 2025
@denysbutenko denysbutenko changed the title NAS-132330 / 25.04 / Nas 132330 NAS-132330 / 25.04 / Update TrueNAS Brand Jan 9, 2025
@denysbutenko denysbutenko requested a review from undsoft January 9, 2025 15:58
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.76%. Comparing base (6e330e6) to head (dfa0def).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ules/layout/admin-layout/admin-layout.component.ts 0.00% 2 Missing ⚠️
...yout/topbar/truenas-logo/truenas-logo.component.ts 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11318      +/-   ##
==========================================
+ Coverage   82.75%   82.76%   +0.01%     
==========================================
  Files        1654     1655       +1     
  Lines       59133    59179      +46     
  Branches     6210     6224      +14     
==========================================
+ Hits        48936    48981      +45     
- Misses      10197    10198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants