-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132705 / 25.04 / Adopts middleware changes to CPU and memory reporting on the dashboard widgets #11317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a number of issues most of them are not because of changes in this PR, but let's still fix them.
- I get
toSignal
error. Can be fixed by adding.pipe(startWith(0))
torefreshInterval$
inWidgetResourcesService
. - I've tried simulating load on CPU to test the widget and noticed that load is reported as System on main chart, but bars don't show much. Looks like an issue with MW reporting. I think users would expect to see total load on bars as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the discrepancy between CPU load in various widgets (System vs User), the rest looks good.
Let's ask MW to look into this.
package.json
Outdated
@@ -80,6 +80,7 @@ | |||
"@lezer/common": "~1.2.1", | |||
"@lezer/generator": "~1.7.1", | |||
"@lezer/lr": "~1.4.2", | |||
"@marijn/find-cluster-break": "~1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this package is needed. It's not used anywhere and it works for me without it. Sounds like an issue on your end.
…o NAS-132705-alt
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11317 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 1659 1659
Lines 59376 59360 -16
Branches 6241 6232 -9
=======================================
- Hits 49184 49173 -11
+ Misses 10192 10187 -5 ☔ View full report in Codecov by Sentry. |
This PR has been merged and conversations have been locked. |
Changes:
Adopts middleware changes to CPU reporting on the dashboard widgets. Removes temperature related reporting also temperature for cpu widget
Testing:
With a recent build, CPU stats related widgets should work correctly. Also shouldn't show any errors in the console logs