Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133299 / 25.04 / Extend window not showing up for spares (by undsoft) #11311

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Jan 8, 2025

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x d45e5d92119e72cadf1cae8f3fde36148ff1c473

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 41e9bb22ba1c9af0d1ce1f5a54fcbd9c30fe3fcf

Testing:

  1. Replace ws.service.ts with attached file.
    ws.service.ts.txt
  2. Navigate to /storage/3/devices/ and test that cards open. Functionality will be limited because of the mock
    , but there should not be console errors.

Original PR: #11303
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133299

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@undsoft undsoft marked this pull request as ready for review January 8, 2025 15:02
@undsoft undsoft requested a review from a team as a code owner January 8, 2025 15:02
@undsoft undsoft requested review from denysbutenko and removed request for a team January 8, 2025 15:02
@undsoft undsoft enabled auto-merge (squash) January 8, 2025 15:02
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.78%. Comparing base (949f96a) to head (edc8d6f).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...disk-details-panel/disk-details-panel.component.ts 0.00% 1 Missing ⚠️
...idz-extend-dialog/raidz-extend-dialog.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11311      +/-   ##
==========================================
- Coverage   82.79%   82.78%   -0.01%     
==========================================
  Files        1654     1654              
  Lines       58961    58963       +2     
  Branches     6194     6196       +2     
==========================================
+ Hits        48814    48815       +1     
- Misses      10147    10148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft disabled auto-merge January 8, 2025 17:17
@undsoft undsoft merged commit 5b85ac2 into master Jan 8, 2025
10 of 11 checks passed
@undsoft undsoft deleted the NAS-133299-25.04 branch January 8, 2025 17:17
@bugclerk
Copy link
Contributor Author

bugclerk commented Jan 8, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants