NAS-133373 / 25.04 / Storage > Disks > Fix remaining display

[bvasilenko]

Changes:

Added factor 100 to "Remaining" column

Testing:

Use the following mockup response for smart.test.results call:

[{"tests": [{"num": 1, "description": "Short offline", "status_verbose": "Completed without error", "remaining": 0.0, "lifetime": 1677, "lba_of_first_error": null, "status": "SUCCESS"}, {"num": 2, "description": "Extended offline", "status_verbose": "Completed without error", "remaining": 0.0, "lifetime": 1656, "lba_of_first_error": null, "status": "SUCCESS"}, {"num": 3, "description": "Extended offline", "status_verbose": "Aborted by host", "remaining": 0.9, "lifetime": 1627, "lba_of_first_error": null, "status": "ABORTED"}, {"num": 4, "description": "Short offline", "status_verbose": "Aborted by host", "remaining": 0.9, "lifetime": 37, "lba_of_first_error": null, "status": "ABORTED"}, {"num": 5, "description": "Extended offline", "status_verbose": "Completed without error", "remaining": 0.0, "lifetime": 25, "lba_of_first_error": null, "status": "SUCCESS"}, {"num": 6, "description": "Short offline", "status_verbose": "Completed without error", "remaining": 0.0, "lifetime": 0, "lba_of_first_error": null, "status": "SUCCESS"}], "current_test": null, "identifier": "{serial_lunid}XXXXXXXX_0000000000000000", "name": "sda", "subsystem": "scsi", "number": 2048, "serial": "XXXXXXXX", "lunid": "0000000000000000", "size": 20000588955648, "description": "", "transfermode": "Auto", "hddstandby": "30", "advpowermgmt": "128", "togglesmart": true, "smartoptions": "", "expiretime": null, "critical": null, "difference": null, "informational": null, "model": "XYZ", "rotationrate": 7200, "type": "HDD", "zfs_guid": "6383777767142087922", "bus": "ATA", "devname": "sda", "enclosure": null, "supports_smart": null, "pool": null, "disk": "sda"}]

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133373

[AlexKarpov98]

Works good 👍

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (464a06e) to head (6cc00fd).
Report is 24 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11309      +/-   ##
==========================================
+ Coverage   82.36%   82.79%   +0.42%     
==========================================
  Files        1658     1654       -4     
  Lines       59087    58961     -126     
  Branches     6206     6194      -12     
==========================================
+ Hits        48666    48814     +148     
+ Misses      10421    10147     -274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.