Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133118 / 25.04 / Add tests for IxFormService #11288

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

RehanY147
Copy link
Contributor

Changes:

Adds tests for

Testing:

Code Review

@RehanY147 RehanY147 requested a review from a team as a code owner January 5, 2025 22:38
@RehanY147 RehanY147 requested review from denysbutenko and removed request for a team January 5, 2025 22:38
@bugclerk bugclerk changed the title NAS-133118: Add tests for IxFormService NAS-133118 / 25.04 / Add tests for IxFormService Jan 5, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Jan 5, 2025

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (9e50429) to head (c3b7293).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11288      +/-   ##
==========================================
+ Coverage   82.55%   82.57%   +0.01%     
==========================================
  Files        1658     1658              
  Lines       59114    59114              
  Branches     6215     6215              
==========================================
+ Hits        48803    48811       +8     
+ Misses      10311    10303       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RehanY147 RehanY147 enabled auto-merge (squash) January 7, 2025 06:36
@RehanY147 RehanY147 merged commit 474b93c into master Jan 7, 2025
9 checks passed
@RehanY147 RehanY147 deleted the NAS-133118 branch January 7, 2025 07:08
@bugclerk
Copy link
Contributor

bugclerk commented Jan 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants