Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133394 / 25.04 / More strict null fixes #11283

Merged
merged 2 commits into from
Jan 6, 2025
Merged

NAS-133394 / 25.04 / More strict null fixes #11283

merged 2 commits into from
Jan 6, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 4, 2025

Testing:

Code review.

@undsoft undsoft requested a review from a team as a code owner January 4, 2025 00:21
@undsoft undsoft requested review from denysbutenko and removed request for a team January 4, 2025 00:21
@bugclerk
Copy link
Contributor

bugclerk commented Jan 4, 2025

@bugclerk bugclerk changed the title NAS-133394: More strict null fixes NAS-133394 / 25.04 / More strict null fixes Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 83.10345% with 49 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (2b5ea90) to head (6efbd5d).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...oudsync/cloudsync-form/cloudsync-form.component.ts 55.88% 15 Missing ⚠️
...oard/components/line-chart/line-chart.component.ts 37.50% 10 Missing ⚠️
...pages/system/enclosure/services/enclosure.store.ts 0.00% 6 Missing ⚠️
...os-keytabs-form/kerberos-keytabs-form.component.ts 0.00% 3 Missing ⚠️
.../directory-service/directory-services.component.ts 0.00% 3 Missing ⚠️
...-selection-vdev/manual-selection-vdev.component.ts 0.00% 3 Missing ⚠️
...nents/custom-app-form/custom-app-form.component.ts 33.33% 2 Missing ⚠️
...ts-dashboard/components/report/report.component.ts 33.33% 2 Missing ⚠️
...ms/ix-forms/services/form-error-handler.service.ts 50.00% 1 Missing ⚠️
...ivilege/privilege-form/privilege-form.component.ts 83.33% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11283      +/-   ##
==========================================
- Coverage   82.35%   82.34%   -0.02%     
==========================================
  Files        1657     1657              
  Lines       59055    59070      +15     
  Branches     6205     6212       +7     
==========================================
+ Hits        48635    48641       +6     
- Misses      10420    10429       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@undsoft undsoft enabled auto-merge (squash) January 6, 2025 16:21
@undsoft undsoft disabled auto-merge January 6, 2025 16:57
@undsoft undsoft merged commit 87e4e4b into master Jan 6, 2025
9 checks passed
@undsoft undsoft deleted the NAS-133394 branch January 6, 2025 16:57
@bugclerk
Copy link
Contributor

bugclerk commented Jan 6, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants