Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133325 / 25.04 / Migrate more instances of OldSlideInService #4 #11278

Merged
merged 12 commits into from
Jan 6, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing: check affected components.

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 3, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 3, 2025 09:33
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team January 3, 2025 09:33
@bugclerk
Copy link
Contributor

bugclerk commented Jan 3, 2025

@bugclerk bugclerk changed the title NAS-133325: Migrate more instances of OldSlideInService #4 NAS-133325 / 25.04 / Migrate more instances of OldSlideInService #4 Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 71.87500% with 54 lines in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (464a06e) to head (f58b938).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/device-list/device-list/device-list.component.ts 30.00% 7 Missing ⚠️
src/app/modules/slide-ins/slide-in.ts 16.66% 5 Missing ⚠️
src/app/pages/storage/pools-dashboard.component.ts 0.00% 5 Missing ⚠️
...tem/bootenv/bootenv-list/bootenv-list.component.ts 28.57% 5 Missing ⚠️
...ed-access-list/authorized-access-list.component.ts 50.00% 4 Missing ⚠️
.../iscsi/extent/extent-list/extent-list.component.ts 50.00% 4 Missing ⚠️
.../iscsi/portal/portal-list/portal-list.component.ts 50.00% 4 Missing ⚠️
...erver/ntp-server-card/ntp-server-card.component.ts 50.00% 4 Missing ⚠️
...ponents/disk-bulk-edit/disk-bulk-edit.component.ts 71.42% 2 Missing ⚠️
.../disks/components/disk-list/disk-list.component.ts 66.66% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11278      +/-   ##
==========================================
- Coverage   82.36%   82.29%   -0.08%     
==========================================
  Files        1658     1658              
  Lines       59087    59084       -3     
  Branches     6206     6206              
==========================================
- Hits        48666    48622      -44     
- Misses      10421    10462      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@undsoft
Copy link
Collaborator

undsoft commented Jan 3, 2025

There is also an issue with boot env clone form where source field is empty.

@AlexKarpov98 AlexKarpov98 merged commit 4e63ed3 into master Jan 6, 2025
8 of 9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133325-new branch January 6, 2025 10:20
@bugclerk
Copy link
Contributor

bugclerk commented Jan 6, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants