Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128883 / 24.10 / Porting jbof #10049

Merged
merged 19 commits into from
May 11, 2024
Merged

NAS-128883 / 24.10 / Porting jbof #10049

merged 19 commits into from
May 11, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented May 10, 2024

Ignore this PR, i'm debugging tests.

@undsoft undsoft requested a review from a team as a code owner May 10, 2024 16:16
@undsoft undsoft requested review from denysbutenko and bugclerk and removed request for a team and denysbutenko May 10, 2024 16:16
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-128883: Porting jbof NAS-128883 / 24.10 / Porting jbof May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 72.63158% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 73.71%. Comparing base (62d0849) to head (540ecb2).
Report is 6 commits behind head on master.

Files Patch % Lines
...shboard/jbof-list/jbof-form/jbof-form.component.ts 24.00% 38 Missing ⚠️
...bel-dialog/set-enclosure-label-dialog.component.ts 87.50% 5 Missing ⚠️
...pages/system/enclosure/services/enclosure.store.ts 0.00% 4 Missing ⚠️
...closure-dashboard/jbof-list/jbof-list.component.ts 95.58% 3 Missing ⚠️
...closure-dashboard/enclosure-dashboard.component.ts 95.45% 1 Missing ⚠️
...ystem/enclosure/utils/get-enclosure-label.utils.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10049      +/-   ##
==========================================
+ Coverage   73.65%   73.71%   +0.05%     
==========================================
  Files        1505     1517      +12     
  Lines       52924    53221     +297     
  Branches     6329     6352      +23     
==========================================
+ Hits        38983    39232     +249     
- Misses      13941    13989      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit fca9739 into master May 11, 2024
10 checks passed
@undsoft undsoft deleted the NAS-128883 branch May 11, 2024 09:35
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants