Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128843 / 24.10 / Add Storage to global search #10046

Merged
merged 4 commits into from
May 12, 2024
Merged

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented May 10, 2024

Screen.Recording.2024-05-11.at.12.43.39.mov

@AlexKarpov98 AlexKarpov98 self-assigned this May 10, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 10, 2024 07:43
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team May 10, 2024 07:43
@bugclerk bugclerk changed the title NAS-128843: Add Storage to global search NAS-128843 / 24.10 / Add Storage to global search May 10, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.73%. Comparing base (62d0849) to head (7a8fd83).
Report is 7 commits behind head on master.

Files Patch % Lines
...omponents/global-search/global-search.component.ts 0.00% 4 Missing ⚠️
...nents/pools-dashboard/pools-dashboard.component.ts 0.00% 3 Missing ⚠️
...ponents/dashboard-pool/dashboard-pool.component.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10046      +/-   ##
==========================================
+ Coverage   73.65%   73.73%   +0.07%     
==========================================
  Files        1505     1522      +17     
  Lines       52924    53262     +338     
  Branches     6329     6356      +27     
==========================================
+ Hits        38983    39271     +288     
- Misses      13941    13991      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@AlexKarpov98 AlexKarpov98 merged commit 4fc801a into master May 12, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128843 branch May 12, 2024 15:57
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants