Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128846 / 24.10 / Do not execute actions when selecting results for Top Panel #10042

Merged
merged 6 commits into from
May 13, 2024

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented May 9, 2024

Testing: see ticket & result 👇

Screen.Recording.2024-05-09.at.13.21.58.mov

I think we don't need to click other buttons as well but only highlight them for the user, to help search where they are.
So what we should click - is only triggerAnchor if it's provided.

@AlexKarpov98 AlexKarpov98 self-assigned this May 9, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 9, 2024 10:23
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team May 9, 2024 10:23
@bugclerk bugclerk changed the title NAS-128846: Do not execute actions when selecting results for Top Panel NAS-128846 / 24.10 / Do not execute actions when selecting results for Top Panel May 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented May 9, 2024

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.80%. Comparing base (6563401) to head (51baa85).
Report is 1 commits behind head on master.

Files Patch % Lines
src/app/directives/common/ui-search.directive.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10042      +/-   ##
==========================================
- Coverage   73.80%   73.80%   -0.01%     
==========================================
  Files        1522     1522              
  Lines       53254    53254              
  Branches     6358     6360       +2     
==========================================
- Hits        39306    39304       -2     
- Misses      13948    13950       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket also asks to add shut down synonyms like "turn off", "reboot" etc.

@AlexKarpov98 AlexKarpov98 requested a review from RehanY147 May 10, 2024 13:36
@undsoft undsoft merged commit 7d54302 into master May 13, 2024
9 of 10 checks passed
@undsoft undsoft deleted the NAS-128846 branch May 13, 2024 14:33
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants