-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-128846 / 24.10 / Do not execute actions when selecting results for Top Panel #10042
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10042 +/- ##
==========================================
- Coverage 73.80% 73.80% -0.01%
==========================================
Files 1522 1522
Lines 53254 53254
Branches 6358 6360 +2
==========================================
- Hits 39306 39304 -2
- Misses 13948 13950 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket also asks to add shut down synonyms like "turn off", "reboot" etc.
This PR has been merged and conversations have been locked. |
Testing: see ticket & result 👇
Screen.Recording.2024-05-09.at.13.21.58.mov
I think we don't need to click other buttons as well but only highlight them for the user, to help search where they are.
So what we should click - is only
triggerAnchor
if it's provided.