NAS-125865: Remove support for clustering (#9362)

src/app/interfaces/api/api-call-directory.interface.ts

@@ -417,9 +417,6 @@ export interface ApiCallDirectory {
   'container.image.query': { params: QueryParams<ContainerImage>; response: ContainerImage[] };
   'container.image.delete': { params: DeleteContainerImageParams; response: void };
 
-  // Cluster
-  'cluster.utils.is_clustered': { params: void; response: boolean };
-
   // Device
   'device.get_info': { params: [DeviceType]; response: Device[] };
 

src/app/pages/sharing/components/shares-dashboard/shares-dashboard.component.html

@@ -1,5 +1,5 @@
 <div class="cards">
-  <ix-smb-card *ixHasRole="[Role.SharingSmbRead]" [isClustered]="isClustered$ | async"></ix-smb-card>
+  <ix-smb-card *ixHasRole="[Role.SharingSmbRead]"></ix-smb-card>
   <ix-nfs-card *ixHasRole="[Role.SharingNfsRead]"></ix-nfs-card>
   <ix-iscsi-card *ixHasRole="[Role.SharingRead]"></ix-iscsi-card>
 </div>

src/app/pages/sharing/components/shares-dashboard/shares-dashboard.component.spec.ts

@@ -2,7 +2,6 @@ import { Spectator, createComponentFactory } from '@ngneat/spectator/jest';
 import { MockComponents } from 'ng-mocks';
 import { MockAuthService } from 'app/core/testing/classes/mock-auth.service';
 import { mockAuth } from 'app/core/testing/utils/mock-auth.utils';
-import { mockCall, mockWebsocket } from 'app/core/testing/utils/mock-websocket.utils';
 import { Role } from 'app/enums/role.enum';
 import { IscsiCardComponent } from 'app/pages/sharing/components/shares-dashboard/iscsi-card/iscsi-card.component';
 import { NfsCardComponent } from 'app/pages/sharing/components/shares-dashboard/nfs-card/nfs-card.component';
@@ -22,9 +21,6 @@ describe('SharesDashboardComponent', () => {
       ),
     ],
     providers: [
-      mockWebsocket([
-        mockCall('cluster.utils.is_clustered', true),
-      ]),
       mockAuth(),
     ],
   });

src/app/pages/sharing/components/shares-dashboard/shares-dashboard.component.ts

@@ -1,17 +1,12 @@
 import { Component } from '@angular/core';
 import { UntilDestroy } from '@ngneat/until-destroy';
 import { Role } from 'app/enums/role.enum';
-import { WebSocketService } from 'app/services/ws.service';
 
 @UntilDestroy()
 @Component({
   templateUrl: './shares-dashboard.component.html',
   styleUrls: ['./shares-dashboard.component.scss'],
 })
 export class SharesDashboardComponent {
-  isClustered$ = this.ws.call('cluster.utils.is_clustered');
-
   readonly Role = Role;
-
-  constructor(private ws: WebSocketService) {}
 }

src/app/pages/sharing/components/shares-dashboard/smb-card/smb-card.component.html

@@ -13,23 +13,13 @@ <h3 class="card-title">
     ></ix-service-state-button>
 
     <div class="actions">
-      <ix-tooltip
-        *ngIf="tableHint"
-        [header]="title | translate"
-        [message]="tableHint | translate"
-      ></ix-tooltip>
-
       <button
         mat-button
         [ixTest]="['smb-share', 'add']"
-        [disabled]="isAddActionDisabled"
         (click)="openForm()"
       >{{ 'Add' | translate }}</button>
 
-      <ix-service-extra-actions
-        *ngIf="!isClustered"
-        [service]="service$ | async"
-      ></ix-service-extra-actions>
+      <ix-service-extra-actions [service]="service$ | async"></ix-service-extra-actions>
     </div>
   </mat-toolbar-row>
 

src/app/pages/sharing/components/shares-dashboard/smb-card/smb-card.component.ts

@@ -1,5 +1,5 @@
 import {
-  ChangeDetectionStrategy, ChangeDetectorRef, Component, Input, OnChanges, OnInit,
+  ChangeDetectionStrategy, ChangeDetectorRef, Component, OnInit,
 } from '@angular/core';
 import { Router } from '@angular/router';
 import { marker as T } from '@biesbjerg/ngx-translate-extract-marker';
@@ -11,7 +11,6 @@ import {
 } from 'rxjs';
 import { ServiceName } from 'app/enums/service-name.enum';
 import { helptextSharingSmb } from 'app/helptext/sharing/smb/smb';
-import { IxSimpleChanges } from 'app/interfaces/simple-changes.interface';
 import { SmbShare, SmbSharesec } from 'app/interfaces/smb-share.interface';
 import { WebsocketError } from 'app/interfaces/websocket-error.interface';
 import { AsyncDataProvider } from 'app/modules/ix-table2/classes/async-data-provider/async-data-provider';
@@ -36,18 +35,13 @@ import { selectService } from 'app/store/services/services.selectors';
   styleUrls: ['./smb-card.component.scss'],
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class SmbCardComponent implements OnInit, OnChanges {
-  @Input() isClustered: boolean;
+export class SmbCardComponent implements OnInit {
   service$ = this.store$.select(selectService(ServiceName.Cifs));
 
   smbShares: SmbShare[] = [];
   dataProvider: AsyncDataProvider<SmbShare>;
   title = T('Windows (SMB) Shares');
 
-  isAddActionDisabled = false;
-  isDeleteActionDisabled = false;
-  tableHint?: string;
-
   columns = createTable<SmbShare>([
     textColumn({
       title: helptextSharingSmb.column_name,
@@ -107,23 +101,6 @@ export class SmbCardComponent implements OnInit, OnChanges {
     private store$: Store<ServicesState>,
   ) {}
 
-  ngOnChanges(changes: IxSimpleChanges<this>): void {
-    if (!changes.isClustered?.currentValue && !!changes.isClustered?.previousValue) {
-      this.updateEnabledFieldVisibility(false);
-      this.isAddActionDisabled = false;
-      this.isDeleteActionDisabled = false;
-      this.tableHint = null;
-    }
-
-    if (!!changes.isClustered?.currentValue && !changes.isClustered?.previousValue) {
-      this.updateEnabledFieldVisibility(true);
-
-      this.isAddActionDisabled = true;
-      this.isDeleteActionDisabled = true;
-      this.tableHint = this.translate.instant('This share is configured through TrueCommand');
-    }
-  }
-
   ngOnInit(): void {
     const smbShares$ = this.ws.call('sharing.smb.query').pipe(
       tap((smbShares) => this.smbShares = smbShares),
@@ -135,17 +112,10 @@ export class SmbCardComponent implements OnInit, OnChanges {
   }
 
   openForm(row?: SmbShare): void {
-    if (this.isClustered) {
-      this.dialogService.info(
-        this.translate.instant(this.title),
-        this.translate.instant(this.tableHint),
-      );
-    } else {
-      const slideInRef = this.slideInService.open(SmbFormComponent, { data: row });
-      slideInRef.slideInClosed$.pipe(filter(Boolean), untilDestroyed(this)).subscribe(() => {
-        this.getSmbShares();
-      });
-    }
+    const slideInRef = this.slideInService.open(SmbFormComponent, { data: row });
+    slideInRef.slideInClosed$.pipe(filter(Boolean), untilDestroyed(this)).subscribe(() => {
+      this.getSmbShares();
+    });
   }
 
   doDelete(smb: SmbShare): void {

src/app/pages/sharing/smb/smb-list/smb-list.component.ts

@@ -2,7 +2,6 @@ import { ChangeDetectionStrategy, Component } from '@angular/core';
 import { Router } from '@angular/router';
 import { UntilDestroy, untilDestroyed } from '@ngneat/until-destroy';
 import { TranslateService } from '@ngx-translate/core';
-import _ from 'lodash';
 import { take } from 'rxjs/operators';
 import { shared, helptextSharingSmb } from 'app/helptext/sharing';
 import { helptextVolumes } from 'app/helptext/storage/volumes/volume-list';
@@ -80,18 +79,6 @@ export class SmbListComponent implements EntityTableConfig<SmbShare> {
     private appLoader: AppLoaderService,
   ) {}
 
-  preInit(entityList: EntityTableComponent<SmbShare>): void {
-    this.entityList = entityList;
-    this.ws.call('cluster.utils.is_clustered').pipe(untilDestroyed(this)).subscribe((isClustered) => {
-      this.isClustered = isClustered;
-      if (this.isClustered) {
-        this.addBtnDisabled = true;
-        this.noAdd = true;
-        _.find(this.entityList.allColumns, { name: helptextSharingSmb.column_enabled }).disabled = true;
-      }
-    });
-  }
-
   afterInit(entityList: EntityTableComponent<SmbShare>): void {
     this.entityList = entityList;
   }

src/assets/i18n/af.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/ar.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/ast.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/az.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/be.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/bg.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/bn.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/br.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/bs.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/ca.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/cs.json

@@ -3507,7 +3507,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",

src/assets/i18n/cy.json

@@ -3935,7 +3935,6 @@
   "This pool has an encrypted root dataset which is locked. Do you want to unlock it?": "",
   "This process continues in the background after closing this dialog.": "",
   "This session is current and cannot be terminated": "",
-  "This share is configured through TrueCommand": "",
   "This system cannot communicate externally.": "",
   "This system will restart when the update completes.": "",
   "This value represents the threshold block size for including small file blocks into the special allocation class. Blocks smaller than or equal to this value will be assigned to the special allocation class while greater blocks will be assigned to the regular class. Valid values are zero or a power of two from 512B  up to 1M. The default size is 0 which means no small file blocks will be allocated in the special class. Before setting this property, a special class vdev must be added to the pool. See <a href=\"https://zfsonlinux.org/manpages/0.7.13/man8/zpool.8.html\" target=\"_blank\">zpool(8)</a> for more details on the special allocation": "",