Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependency): refactor gradle dependencies #5625

Conversation

tomatoishealthy
Copy link
Contributor

What does this PR do?

close #5561

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@tomatoishealthy tomatoishealthy force-pushed the feature/gradle-dependency-refactor branch from 72049de to c0e2e06 Compare December 20, 2023 03:47
compileOnly 'org.projectlombok:lombok:1.18.12'
annotationProcessor 'org.projectlombok:lombok:1.18.12'
testCompileOnly 'org.projectlombok:lombok:1.18.12'
testAnnotationProcessor 'org.projectlombok:lombok:1.18.12'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you simplify the dependency org.projectlombok:lombok:1.18.12?

Copy link
Contributor Author

@tomatoishealthy tomatoishealthy Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I am not very clear about the differences between these.

How should I optimize them, do you have any suggestions?

Reference: https://stackoverflow.com/questions/50519138/annotationprocessor-gradle-4-7-configuration-doesnt-run-lombok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does compile 'org.projectlombok:lombok:1.18.12'work ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't work

@halibobo1205 halibobo1205 merged commit 20fc9b9 into tronprotocol:develop Dec 27, 2023
3 checks passed
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.4 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle dependency refactor
3 participants