Implement Morris surface tension model #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 70.53% 69.81% -0.72%
==========================================
Files 96 96
Lines 5976 6139 +163
==========================================
+ Hits 4215 4286 +71
- Misses 1761 1853 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Aug 15, 2024
Merged
svchb
added a commit
to svchb/TrixiParticles.jlOpen
that referenced
this pull request
Sep 27, 2024
svchb
added a commit
to svchb/TrixiParticles.jlOpen
that referenced
this pull request
Sep 27, 2024
Closed
…e_surface_normal_calc
Conflicts: examples/fluid/dam_break_oil_film_2d.jl src/schemes/fluid/weakly_compressible_sph/density_diffusion.jl src/schemes/fluid/weakly_compressible_sph/rhs.jl src/schemes/fluid/weakly_compressible_sph/state_equations.jl src/schemes/fluid/weakly_compressible_sph/system.jl src/visualization/write2vtk.jl
…ris_surface_tension
@efaulhaber still the case |
…xiParticles.jlOpen into generalize_surface_normal_calc
LasNikas
pushed a commit
that referenced
this pull request
Jan 30, 2025
* fix merge * fix merge * fix merge * fix merge * fix merge * more merge fixes * format * fix * fix * fix * fix * fix * more fixes * fix * fix * fix * more fixes * fix * fix * format * running * update * update * optimization * update * update * update * update * format * up * update * remove unused code * switch to support radius * update * fix doc * add adhesion coefficient * update_broken * update * format * add to examples * fix tests * fix merge * fix typos * add basic test * format * rename * format * rename container system * reduce example run time * update news and readme * format * fix test * reduce run time * format * fix * correct merge * update doc test * revert * fix tests * fix * fix * review comments * fix * fix * correct some stuff * init with empty initial condition * review update * rename function * remove unnecessary if * docs * fix doc * revert one change * fix typo * update * try to avoid allocs * fix mem allocs * review update * update docs * update * review * fix * format * make examples smaller * reduce resolution * review * rename * use trixi_include * format * use trixi_include * update * update * review update * format * fix test errors * update * fix * remove invalid surface normals * add * fix * update * update * update * fix * update * update * update * remove unused * remove unused * format * fix tests * fix * fix * fix naming * format * fix test * set test up for 1.11 * fix test * rename to number_density * back merge * fix * format * fix * fix tests * back merge from #584 * move additonal changes from #584 * add test * add test * format * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <[email protected]> * format * Update news and set to 0.2.4 * update * fix MD format * Update NEWS.md * some fixes * add docs * review fixes * remove independent setting of smoothing_kernel and smoothing_length * remove calls to surface_normal method smoothing kernel * format * update news * typo * Update NEWS.md * forgot some renames * fix doc tests * fix docs * fix tests * format * Update NEWS.md * fix tests * Update NEWS.md * fix * fix * fix * fix * review fixes * review comments * fix test * typo * review updates * review update * add boundary system * update * update * format * remove color since it is unused in this PR * review comment * format * merge error * review comment * fix * remove surface_normal_method() * merge error * function was renamed in PN * format * fix test * fix error * fix * review comments * review comments * review comments * format * merge * format * add comment * remove ideal_neighbor() * format * typo * add missing docs * only initialize necessary values * fix test * fix examples --------- Co-authored-by: Erik Faulhaber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #539
Depends on #604
Depends on #605
Depends on #606
Depends on #607
Depends on #608
Depends on #609
Depends on #599
super seeds #523